-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bentoml to 1.2.28 and 1.1.21 #2704
Conversation
Signed-off-by: Andrea Lamparelli <[email protected]>
Locally I am experiencing a failure running 2024-05-07T08:38:31+0000 [ERROR] [api_server:1] Exception on /is_fraud [POST] (trace=fe8f5861ac58e7997bf04620e99e67ba,span=62350ba5fd974236,sampled=0)
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/bentoml/_internal/server/http_app.py", line 324, in api_func
output = await api.func(input_data)
File "/home/bentoml/bento/src/service.py", line 34, in is_fraud
results = await asyncio.gather(*[_is_fraud(p, r, input_df) for p, r in zip(fraud_detection_preprocessors, fraud_detection_runners)])
File "/home/bentoml/bento/src/service.py", line 28, in _is_fraud
input_features = preprocessor.transform(input_df)
File "/usr/local/lib/python3.10/site-packages/sklearn/utils/_set_output.py", line 140, in wrapped
data_to_wrap = f(self, X, *args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 800, in transform
Xs = self._fit_transform(
File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 652, in _fit_transform
transformers = list(
File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 349, in _iter
transformers = [
File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 350, in <listcomp>
replace_passthrough(*trans) for trans in self.transformers_
File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 345, in replace_passthrough
if name not in self._name_to_fitted_passthrough:
AttributeError: 'ColumnTransformer' object has no attribute '_name_to_fitted_passthrough' @juliusvonkohout any idea? Anyway, let's see if the same error happens here in the GHA |
@yubozhao you need to maintain bentoml or we need to consider removing it from Kubeflow |
Maybe we need to upgrade from https://github.com/bentoml/Fraud-Detection-Model-Serving |
In the worst case you have to drop some test parts until it is working again. This is fine for /contrib stuff. |
Signed-off-by: Andrea Lamparelli <[email protected]>
Yeah, maybe yes as it looks like it is using
If this is acceptable, I think it is enough to skip the |
This is just /contrib which shall not block the release, so /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, lampajr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]>
* Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update readme (#2707) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <[email protected]> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
* Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <[email protected]> * update readme (#2707) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <[email protected]> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <[email protected]> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * Fixes for dco changes (#2713) * Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update readme (#2707) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <[email protected]> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
* Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]>
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <[email protected]> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <[email protected]> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <[email protected]> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <[email protected]> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * Fixes for dco changes (kubeflow#2713) * Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <[email protected]> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <[email protected]> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <[email protected]> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
Which issue is resolved by this Pull Request:
As suggested #2693 (comment) I am proposing to update
betnoml
manifestsDescription of your changes:
Following the
UPGRADE.md
instructions I updatedcontrib/bentoml
with the latest version content.Checklist:
Make sure you have installed kustomize == 5.2.1+
make generate-changed-only
make test