Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeflow/kfp-tekton manifests from v2.0.3 #2563

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Oct 28, 2023

Description of your changes:
To align with kfp 2.0.3, also update kfp-tekton to 2.0.3

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yhwang
Copy link
Member Author

yhwang commented Oct 30, 2023

/assign @kimwnasptd @PatrickXYS

@yhwang
Copy link
Member Author

yhwang commented Oct 31, 2023

@danisla, want to make sure this could be included in the final release. Do you know who could approve this before you cut the release?

@DnPlas
Copy link
Contributor

DnPlas commented Oct 31, 2023

hey @yhwang this will be included in the upcoming release. we just need @kimwnasptd's approval.

@yhwang
Copy link
Member Author

yhwang commented Nov 1, 2023

hey @yhwang this will be included in the upcoming release. we just need @kimwnasptd's approval.

Thanks for the confirmation.
The reason I want to double-check with you is that we already put kfp-tekton 2.0.3 in the release blog post. So I want to make sure this will be included in the v1.8.

@kimwnasptd
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 93d8379 into kubeflow:v1.8-branch Nov 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants