Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove creationTimestamp line #2509

Closed
wants to merge 1 commit into from
Closed

Conversation

Linchin
Copy link

@Linchin Linchin commented Aug 16, 2023

Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#7041, GoogleCloudPlatform/kubeflow-distribution#431

Description of your changes:
When deploying KF 1.7 on GCP, this line,

creationTimestamp: null

caused the following error in deployment:

error: unable to decode "apps/profiles/build/apiextensions.k8s.io_v1_customresourcedefinition_profiles.kubeflow.org.yaml": parsing time "null" as "2006-01-02T15:04:05Z07:00": cannot parse "null" as "2006"

This seems to be due to golang being unable to handle null when unmarshalling timestamp. Currently, users have to manually remove this line every time for the deployment to succeed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Linchin
Once this PR has been reviewed and has the lgtm label, please assign yanniszark for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

/lgtm

@Linchin
Copy link
Author

Linchin commented Aug 21, 2023

/assign @kimwnasptd

@Linchin
Copy link
Author

Linchin commented Sep 11, 2023

/assign @yanniszark

@juliusvonkohout
Copy link
Member

Most of our approvers have left the project. I think only Kimonas is left. I'll try to be able to approve such stuff in the future, but it will probably take a few months to become approver. Maybe join the notebooks WG or manifest WG meeting.

@Linchin
Copy link
Author

Linchin commented Sep 12, 2023

Thank you @juliusvonkohout for explaining the situation! I have also messaged Kimonas on slack.

@zijianjoy
Copy link
Contributor

@DnPlas is the release manager for this coming Kubeflow release, so tagging here to increase visibility.

Let's make the change in https://github.com/kubeflow/kubeflow/blob/master/components/profile-controller/config/crd/bases/kubeflow.org_profiles.yaml#L7 which is the upstream of this file.

@Linchin
Copy link
Author

Linchin commented Sep 12, 2023

Thank you @zijianjoy, I will create a PR over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubeflow v1.6.1 fails deployment during make-apply
5 participants