-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove creationTimestamp line #2509
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Linchin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/assign @kimwnasptd |
/assign @yanniszark |
Most of our approvers have left the project. I think only Kimonas is left. I'll try to be able to approve such stuff in the future, but it will probably take a few months to become approver. Maybe join the notebooks WG or manifest WG meeting. |
Thank you @juliusvonkohout for explaining the situation! I have also messaged Kimonas on slack. |
@DnPlas is the release manager for this coming Kubeflow release, so tagging here to increase visibility. Let's make the change in https://github.com/kubeflow/kubeflow/blob/master/components/profile-controller/config/crd/bases/kubeflow.org_profiles.yaml#L7 which is the upstream of this file. |
Thank you @zijianjoy, I will create a PR over there. |
Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#7041, GoogleCloudPlatform/kubeflow-distribution#431
Description of your changes:
When deploying KF 1.7 on GCP, this line,
caused the following error in deployment:
This seems to be due to golang being unable to handle
null
when unmarshalling timestamp. Currently, users have to manually remove this line every time for the deployment to succeed.