Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib 0.10 v1beta1 release #1593

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Oct 26, 2020

Which issue is resolved by this Pull Request:
Related: kubeflow/katib#1360.
Blocked by: kubeflow/katib#1356, kubeflow/katib#1355, kubeflow/katib#1339.
The manifests are ready, but I need to change images once we release them.

/assign @johnugeorge @gaocegege
/cc @jlewi

Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@Jeffwan
Copy link
Member

Jeffwan commented Oct 29, 2020

Hi @andreyvelich Is this the version you like to release in kubeflow 1.2?

@andreyvelich
Copy link
Member Author

@Jeffwan Yes, I am waiting for this: kubeflow/katib#1344.
After, I'll update manifests with the latest images / manifest changes.

@andreyvelich
Copy link
Member Author

I changed image tag to v1beta1-e294a90, let's merge this PR for the new manifests changes.
If we need to update tag for the Katib 0.10, I'll do it in the following PR.
Please, take a look @gaocegege @johnugeorge.

@andreyvelich andreyvelich changed the title [WIP] Katib 0.10 v1beta1 release Katib 0.10 v1beta1 release Nov 2, 2020
@andreyvelich
Copy link
Member Author

/retest

@Jeffwan
Copy link
Member

Jeffwan commented Nov 2, 2020

fatal: could not create leading directories of '/mnt/test-data-volume/kubeflow-manifests-presubmit-unit-1593-928486b-2768-a695/src/ku
beflow/manifests': No space left on device

@andreyvelich Have you tried this to clean up disk ?https://github.com/kubeflow/testing/blob/master/playbook/playbook.md#nfs-volume-is-out-of-disk-space

@andreyvelich
Copy link
Member Author

andreyvelich commented Nov 2, 2020

@Jeffwan It seems to be full: dashboard, let me try to follow first way to delete it.
/cc @jlewi

@andreyvelich
Copy link
Member Author

/retest

@jlewi jlewi removed their request for review November 3, 2020 00:42
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5c2ae32 into kubeflow:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants