Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tekton-catalog): Refactor kfptask #1435

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Dec 19, 2023

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli Tomcli changed the title (wip) fix(tekton-catalog): Refactor kfptask fix(tekton-catalog): Refactor kfptask Dec 19, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Dec 19, 2023

/assign @yhwang
e2e passed: https://cloud.ibm.com/devops/pipelines/tekton/f3b948d5-053c-45bf-a82f-8e65338b2e32/runs/8b92c3fa-026d-49a4-a74a-170db0d9f827/test/run-go-unittests?env_id=ibm:yp:us-south

Need to refactor this code because the kfptask common functions were from the reconciler package which also initiated the kfptask watcher client that can impact our performance.

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 19, 2023
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 09b39c7 into kubeflow:master Dec 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants