fix(pipelineloop): update pipelineloop v1 bug #1330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Fix the one place where the pipeline is updated with v1beta1 during pipeline cancellation. Somehow it was able to pass all the unit tests with the v1beta1 to v1 conversion but randomly converted into the wrong v1 spec in 1/10 chance with the real tekton controller
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist: