Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): enhance build scripts #1200

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Apr 3, 2023

Description of your changes:
enhance toolchains scripts to avoid build failures we observed recently

Checklist:

Don't fail the script if there is no pod after the deployment.
Instead, do the check again after the sleep.
use randomized pipeline name to support retry
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Apr 3, 2023
@google-oss-prow google-oss-prow bot merged commit 4764448 into kubeflow:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants