Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): make metadata component spec gen flag configurable on pipeline level #1177

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Mar 2, 2023

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
The flag for disabling component spec annotation metadata was only available on package level, we want to expose this flag on pipeline level as well so our users can control what pipeline is allowed to be tracked for metadata.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Mar 3, 2023

/assign @yhwang

@Tomcli
Copy link
Member Author

Tomcli commented Mar 3, 2023

cc @typeness

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhwang
Copy link
Member

yhwang commented Mar 6, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 6, 2023
@google-oss-prow google-oss-prow bot merged commit d196a94 into kubeflow:master Mar 6, 2023
Tomcli added a commit that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants