add disk setting into suggestionConfiguration #989
Conversation
|
Hi @sperlingxx. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sperlingxx
changed the title
|
@sperlingxx Do you meet any problem with the disk when you use katib? Did these suggestions consume much disk space? It should not happen by design. The suggestions are designed to be stateless, and they should not use disks. |
| if !cpuLimit.IsZero() { | ||
| suggestionConfigData[consts.LabelSuggestionCPULimitTag] = cpuLimit.String() | ||
| } | ||
| if !memLimit.IsZero() { | ||
| suggestionConfigData[consts.LabelSuggestionMemLimitTag] = memLimit.String() | ||
| } | ||
| if !diskLimit.IsZero() { | ||
| suggestionConfigData[consts.LabelSuggestionDiskRequestTag] = diskLimit.String() |
There was a problem hiding this comment.
| suggestionConfigData[consts.LabelSuggestionDiskRequestTag] = diskLimit.String() | |
| suggestionConfigData[consts.LabelSuggestionDiskLimitTag] = diskLimit.String() |
Thanks for so quick reviewing. I add this setting for two concerns:
|
|
SGTM. Thanks. #989 (comment) One typo-fix suggestion here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Thanks for your contribution! 🎉 👍 |
The aim of this PR is appending the setting of disk(EphemeralStorage) into configuration of suggestion service.
This change is