feat: Refactor to make it easy to extend new kinds #865
Conversation
|
/assign @johnugeorge @hougangliu |
|
/lgtm |
|
Addressed the comment, PTAL @johnugeorge |
| // Katib will inject metrics collector into master replica. | ||
| var JobRoleMap = map[string][]string{ | ||
| // Job kind does not support distributed training, thus no master. | ||
| consts.JobKindJob: {}, |
There was a problem hiding this comment.
@gaocegege Just wondering why don't we keep all job related constants in this file?
There was a problem hiding this comment.
We cannot do it since it will cause import cycle. If we defined consts in job/v1alpha3, job/v1alpha3 uses job/v1alph3/job, job/v1alph3/job uses consts defined in job/v1alpha3.
There was a problem hiding this comment.
Does it work for you? @johnugeorge
There was a problem hiding this comment.
I feel that we have defined too many constants :)
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
|
Ready to be merged? |
|
I think so. |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: Ce Gao [email protected]
What this PR does / why we need it:
This PR introduces a new Interface Provider, to make it easy to add new kinds.
Special notes for your reviewer:
Release note:
This change is