feat: Show all experiments in monitor #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
changed the title
hougangliu
reviewed
Sep 29, 2019
pkg/ui/v1alpha3/backend.go
Outdated
| if experiment.Spec.NasConfig != nil { | ||
| experimentLastCondition, err := experiment.GetLastConditionType() | ||
| if err != nil { | ||
| log.Printf("GetLastConditionType for HP failed: %v", err) |
pkg/ui/v1alpha3/backend.go
Outdated
|
|
||
| el, err := k.katibClient.GetExperimentList(namespace) | ||
| if err != nil { | ||
| log.Printf("GetExperimentList for NAS failed: %v", err) |
There was a problem hiding this comment.
it seems the experiment list will include all kinds of experiment, not only NAS
pkg/ui/v1alpha3/backend.go
Outdated
| jobs := make([]JobView, 0) | ||
|
|
||
| el, err := k.katibClient.GetExperimentList() | ||
| jobs, err := k.getExperimentList(consts.DefaultKatibNamespace) |
There was a problem hiding this comment.
why only consts.DefaultKatibNamespace?
pkg/ui/v1alpha3/backend.go
Outdated
| http.Error(w, err.Error(), http.StatusInternalServerError) | ||
| return | ||
| } | ||
| log.Printf("?????: %v", jobs) |
There was a problem hiding this comment.
It is still WIP, some bugs are not fixed. Thus it is a WIP log.
There was a problem hiding this comment.
Missed WIP tag, please go ahead
pkg/ui/v1alpha3/backend.go
Outdated
| log.Printf("?????: %v", jobs) | ||
| response, err := json.Marshal(jobs) | ||
| if err != nil { | ||
| log.Printf("Marshal NAS jobs failed: %v", err) |
|
|
gaocegege
commented
Sep 29, 2019
gaocegege
changed the title
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
|
/retest |
johnugeorge
reviewed
Sep 29, 2019
Signed-off-by: Ce Gao <[email protected]>
|
/assign @johnugeorge |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
This change is