Enabled make check in travis. #608
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gyliu513
force-pushed
the
trvis-make-check
branch
from
2e9770d
to
df2978b
Compare
| - "1.10" | ||
| - "1.11" | ||
| - "1.12" | ||
| - "1.12.5" |
There was a problem hiding this comment.
I followed kubefed here kubernetes-retired/kubefed#902 , it is always good to use latest stable version.
There was a problem hiding this comment.
Personally, I do not think so. I think we should support multiple go versions.
There was a problem hiding this comment.
Different go version sometimes have different standard. In my previous PR, I found that gofmt always failed in go1.10 but succeed in go 1.12 and go 1.11, this caused the make check failed. Using the latest go can leverage the latest features in Go.
There was a problem hiding this comment.
Yeah, go 1.10 can be removed. Format check may be failed in 1.10. I also noticed it.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #607
Special notes for your reviewer:
Release note:
/cc @gaocegege @hougangliu @johnugeorge
This change is