Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use manager client to get log for test #569

Merged
merged 2 commits into from
May 23, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 22, 2019

Signed-off-by: Ce Gao [email protected]

What this PR does / why we need it:

Now the code to communicate with katib manager to get the log is hard coded in the main workflow. Thus we cannot run unit test because in unit test we do not have such a manager instance. This PR moves the function call to managerclient to mock it in test.

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

Copy link
Member Author

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

@johnugeorge Addressed, PTAL

@hougangliu
Copy link
Member

/lgtm

Copy link
Member Author

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 42dc4c8 into kubeflow:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants