Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated TODOs in README.md #468

Merged
merged 1 commit into from
May 7, 2019
Merged

Remove outdated TODOs in README.md #468

merged 1 commit into from
May 7, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Apr 24, 2019 •
edited by jlewi
Loading

I believe these are outdated. TODOs can be found in issues/code.

This change is Reviewable

hougangliu
hougangliu reviewed Apr 24, 2019
View reviewed changes
README.md

* Integrate KubeFlow (TensorFlow, Caffe2 and PyTorch operators)
* Support Early Stopping
* Enrich the GUI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these TODOs aren't still done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is README though. Should they be tracked somewhere else, e.g. roadmap, issues, story board, etc.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, maybe you can create a doc to trace it

Copy link
Member

@gaocegege gaocegege Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use issues to keep track of the TODO items. WDYT I think we already have such issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@hougangliu
Copy link
Member

/lgtm
@terrytangyuan Thanks for your first PR of katib.

@terrytangyuan
Copy link
Member Author

Anyone wants to merge this tiny PR? :-)

@hougangliu
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member Author

/retest

4 similar comments
@terrytangyuan
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

/retest

@terrytangyuan
Copy link
Member Author

/retest

@terrytangyuan
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6d95830 into kubeflow:master May 7, 2019
@terrytangyuan terrytangyuan deleted the patch-1 branch May 7, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@hougangliu hougangliu hougangliu left review comments

@garganubhav garganubhav Awaiting requested review from garganubhav

@jose5918 jose5918 Awaiting requested review from jose5918

Assignees

@hougangliu hougangliu

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terrytangyuan @hougangliu @k8s-ci-robot @johnugeorge @gaocegege