Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding master pod check for default metric collector #300

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Dec 19, 2018

For distributed TFJob/PyTorchJob, logs are collected only from the pod that acts as the master of the job.

Fixes: #294


This change is Reviewable

@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

/assign @richardsliu
/assign @YujiOshima

@hougangliu
Copy link
Member

/lgtm

@YujiOshima
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8e89813 into kubeflow:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants