Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bayesian optimization suggestion #251

Merged
merged 4 commits into from
Dec 4, 2018
Merged

fix bayesian optimization suggestion #251

merged 4 commits into from
Dec 4, 2018

Conversation

YujiOshima
Copy link
Contributor

@YujiOshima YujiOshima commented Nov 19, 2018 •
edited by jlewi
Loading

Fix #217

  • Use the latest API
  • Enable get multi trials (sampling from buckets instead of get the Maximum likelihood)
  • Introduce burn-in sampling. Sample trials randamly in the first burn-in number.

/cc @richardsliu @xyhuang
Signed-off-by: YujiOshima [email protected]

This change is Reviewable

xyhuang
xyhuang reviewed Nov 21, 2018
View reviewed changes
pkg/suggestion/bayesian_service.py
model_types = ["gp", "rf"]
kernel_types = ["matern", "rbf"]

for param in params:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need some input validations here for the param values like that in the original code, or are they already handled elsewhere?
also in the inner if-else conditions it might be cleaner to use if param.name in [...] than a list of ors (i know it's from the original code so not sure if it should change).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a review! Updated.

@YujiOshima
validate parameters
ce2cb51 
Signed-off-by: YujiOshima <[email protected]>
@YujiOshima
Copy link
Contributor Author

/retest

@YujiOshima
Copy link
Contributor Author

@xyhuang Could you take another look?

@xyhuang
Copy link
Member

xyhuang commented Dec 1, 2018

thanks @YujiOshima!
/lgtm
you might want to have a second look from someone else.

@YujiOshima
Copy link
Contributor Author

@xyhuang Thank you!
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1104524 into kubeflow:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyhuang xyhuang xyhuang left review comments

@richardsliu richardsliu Awaiting requested review from richardsliu

Assignees

@xyhuang xyhuang

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YujiOshima @xyhuang @k8s-ci-robot