Tf event mc #235
Tf event mc #235
Conversation
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
|
@YujiOshima really glad to see this coming along. Anything we can do to help? I'm going to assk @richardsliu to be one of the lead reviewers for this. |
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
|
@jlewi @richardsliu Thanks! I added a doc for TF Event metrics collector. |
|
/retest |
1 similar comment
|
/retest |
| yield root | ||
| for f in files: | ||
| yield os.path.join(root, f) | ||
| def parse_summary(self, tfefile, metrics): |
There was a problem hiding this comment.
Can you add a comment with an example log and expected output?
| if os.path.isdir(f): | ||
| continue | ||
| try: | ||
| print(f+" will be parse.") |
| with api_pb2.beta_create_Manager_stub(channel) as client: | ||
| gsrep = client.GetStudy(api_pb2.GetStudyRequest(study_id=study_id), 10) | ||
| self.metrics = gsrep.study_config.metrics | ||
| self.Parser = TFEventFileParser() |
| for m in ml: | ||
| mls.append(ml[m]) | ||
| except: | ||
| print("Unexpected error:", sys.exc_info()[0]) |
There was a problem hiding this comment.
Use the logging library if possible.
cmd/tfevent-metricscollector/main.py
Outdated
| va.value = v.value | ||
| channel = grpc.beta.implementations.insecure_channel(opt.manager_addr, opt.manager_port) | ||
| with api_pb2.beta_create_Manager_stub(channel) as client: | ||
| print("In " + mlset.worker_id + " " + str(len(mlset.metrics_logs)) + " metrics will be reported.") |
There was a problem hiding this comment.
Use the logging library if possible
Signed-off-by: YujiOshima <[email protected]>
|
@richardsliu Thank you for your review. I updated! |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu, YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a metrics collector for TF-Event file.
Related #221 #173
There is no doc now. I will add some docs.
@jlewi @gaocegege
This change is