Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retry an INSERT operation on unique constraint violation #229

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

toshiiw
Copy link
Contributor

@toshiiw toshiiw commented Oct 29, 2018

The retry logic is used to generate an unique ID, but if there is
another error the DB code can fall into an infinite loop.

Signed-off-by: IWAMOTO Toshihiro [email protected]


This change is Reviewable

@gaocegege
Copy link
Member

/ok-to-test

The retry logic is used to generate an unique ID, but if there is
another error the DB code can fall into an infinite loop.

Signed-off-by: IWAMOTO Toshihiro <[email protected]>
@YujiOshima
Copy link
Contributor

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f87fd8 into kubeflow:master Nov 1, 2018
@toshiiw toshiiw deleted the fix-db-id-gen branch November 2, 2018 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants