Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add namespace parameter to KatibClient #2183

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

droctothorpe
Copy link
Contributor

@droctothorpe droctothorpe commented Jul 31, 2023

What this PR does / why we need it:
This PR lets users specify namespace in the KatibClient constructor. This alleviates the need to manually pass it every single time you invoke one of the many methods, improving UX. This PR also sorts the imports in katib_client.py.

Which issue(s) this PR fixes:
Fixes #2180

Checklist:

  • Docs included if any changes are user facing
    ^ Not relevant since we haven't modified the UX, just added an alternative mechanism for setting namespace.

Co-authored-by: andreafehrman <[email protected]>
Co-authored-by: ryanrusson <[email protected]>
@droctothorpe
Copy link
Contributor Author

@andreyvelich 👍

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great improvement @droctothorpe!
I left a few comments.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @droctothorpe!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, droctothorpe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droctothorpe
Copy link
Contributor Author

Thank you @droctothorpe! /lgtm /approve

Thanks, @andreyvelich!

@andreyvelich andreyvelich mentioned this pull request Aug 1, 2023
6 tasks
@google-oss-prow google-oss-prow bot merged commit b7295cb into kubeflow:master Aug 1, 2023
59 checks passed
@droctothorpe droctothorpe deleted the namespace branch August 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable namespace specification in KatibClient class
2 participants