Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwa(front): Support all namespaces #2119

Conversation

elenzio9
Copy link
Contributor

This PR adds support for all-namespaces in KWA.

image

Related PR: kubeflow/kubeflow#6958

@orfeas-k
Copy link
Contributor

The code looks good. I also tested the image in my cluster and works as expected. Thank you @elenzio9!
/lgtm
cc @kimwnasptd

@tenzen-y
Copy link
Member

/assign @kimwnasptd

@kimwnasptd
Copy link
Member

@tasos-ale could you take a stab at this?

/cc @tasos-ale

@elenzio9 elenzio9 force-pushed the feature-elena-kwa-support-all-namespaces branch from 986e13a to db7785e Compare February 20, 2023 12:02
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 20, 2023
Add support for all-namespaces in KWA.

Signed-off-by: Elena Zioga <[email protected]>
@elenzio9 elenzio9 force-pushed the feature-elena-kwa-support-all-namespaces branch from db7785e to 318b35c Compare February 20, 2023 13:55
Copy link

@tasos-ale tasos-ale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elenzio9! @kimwnasptd LGTM

@kimwnasptd
Copy link
Member

Will go on and merge the CentralDashboard one as well kubeflow/kubeflow#6958

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 24, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd, tasos-ale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2e27185 into kubeflow:master Feb 24, 2023
@kimwnasptd kimwnasptd deleted the feature-elena-kwa-support-all-namespaces branch February 24, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants