New UI for Katib #208
Merged
New UI for Katib #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
Signed-off-by: YujiOshima <[email protected]>
|
Is it ready to review? |
Signed-off-by: YujiOshima <[email protected]>
|
@gaocegege Yes! I fixed test and it is ready to review! |
|
/retest |
|
So this UI doesn't depend on ModelDB? So where is the data stored? Is the data stored in ModelDB but using the Katib API to fetch this? |
|
@jlewi The data is stored in KatibDB(MySQL). |
|
Could we merge it now? |
|
@gaocegege Yes! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
toshiiw
added a commit
to toshiiw/katib
that referenced
this pull request
Oct 30, 2018
Signed-off-by: IWAMOTO Toshihiro <[email protected]>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 2, 2018
Signed-off-by: IWAMOTO Toshihiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new UI for Katib.
This only depends on Katib API.
Add
GetWorkerFullInfoAPI.Get Worker, Parameters, Metrics logs corresponded to ID in an argument all at once.
This change is