Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resources to earlystopping container #2038

Merged
merged 1 commit into from
Dec 2, 2022
Merged

add resources to earlystopping container #2038

merged 1 commit into from
Dec 2, 2022

Conversation

zhixian82
Copy link
Contributor

Fixes #2037

andreyvelich
andreyvelich reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @zhixian82!
Please can you update the unit test with Early Stopping container resources ?

@zhixian82 zhixian82 force-pushed the earlystopping-container-support-resource branch from ad6b4b1 to c9ef340 Compare November 29, 2022 03:26
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Nov 29, 2022
@zhixian82
Copy link
Contributor Author

Thank you for this update @zhixian82! Please can you update the unit test with Early Stopping container resources ?

Done

@zhixian82 zhixian82 force-pushed the earlystopping-container-support-resource branch from c9ef340 to e4ce0d5 Compare December 2, 2022 03:23
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 2, 2022
@andreyvelich
Copy link
Member

Thanks @zhixian82!
/lgtm
/assign @tenzen-y @johnugeorge

@google-oss-prow google-oss-prow bot added the lgtm label Dec 2, 2022
@johnugeorge
Copy link
Member

Thanks @zhixian82

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, zhixian82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3cbf3ec into kubeflow:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@anencore94 anencore94 Awaiting requested review from anencore94

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@johnugeorge johnugeorge

@andreyvelich andreyvelich

@tenzen-y tenzen-y

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set earlyStopping container resource requests/limits
4 participants
@zhixian82 @andreyvelich @johnugeorge @tenzen-y