Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated yaml tab for Trials #2034

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

elenzio9
Copy link
Contributor

This PR introduces a new yaml tab in the Trial details page that shows the full YAML as it comes from the backend.

Here's a screenshot:
image

Related issue: #2011

@johnugeorge
Copy link
Member

Great work @elenzio9

@johnugeorge
Copy link
Member

Related Issue for Suggestion: #1439

@kimwnasptd
Copy link
Member

@orfeas-k since you've also helped with developing the monaco editor component kubeflow/kubeflow#6733 could you also take a stab at the review?

/cc @kimwnasptd
/cc @orfeas-k

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit @elenzio9 you could rename openTrialModal() as well. Everything else lgtm @kimwnasptd

* Create a dedicated yaml tab for Trials.

Signed-off-by: Elena Zioga <[email protected]>
* Rename trial-modal component to trial-details.
* Rename trial-modal-overview component to trial-overview.

Signed-off-by: Elena Zioga <[email protected]>
@orfeas-k
Copy link
Contributor

/lgtm

@kimwnasptd
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7f4eb27 into kubeflow:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants