frontend: Enable sorting in KWA's main table #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenzio9
changed the title
|
@elenzio9 I see there's a conflict in the common commit. Could you resolve it? We should be good to merge afterwards |
* Enable the sorting functionality in KWA's main table. Signed-off-by: Elena Zioga <[email protected]>
elenzio9
force-pushed
the
WIP-feature-elena-kwa-sorting
branch
from
6775c67
to
7d12bed
Compare
tenzen-y
reviewed
Dec 5, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables sorting in KWA's main table based on the following columns:
Here's a screenshot of the app:
I marked this PR as
WIPsince I couldn't build an image and tested in my cluster because of the bug reported here: #2016Update: Managed to build an image and tested in my cluster. It worked as expected!
Related PRs: kubeflow/kubeflow#6742