Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64 in mxnet-mnist image #1940

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Aug 28, 2022

What this PR does / why we need it:
I modified Dockerfile for mxnet-mnist to support arm64. Also, I upgraded mxnet version to v1.9.1.
I have tested using the following commands:

$ # For linux/amd64
$ docker run -it --pull always --platform=linux/amd64 ytenzen/multiplatform-mxnet:latest
$ # For linux/arm64
$ docker run -it --pull always --platform=linux/arm64 ytenzen/multiplatform-mxnet:latest

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #1900

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Aug 28, 2022

Coverage Status

Coverage decreased (-0.09%) to 73.545% when pulling f05cbf0 on tenzen-y:support-arm64-for-mxnet-trial-image into ca903e2 on kubeflow:master.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3906f8e into kubeflow:master Aug 29, 2022
@tenzen-y tenzen-y deleted the support-arm64-for-mxnet-trial-image branch August 29, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants