Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix]: filter by name of experiment #1920

Merged

Conversation

anencore94
Copy link
Member

@anencore94 anencore94 commented Jul 27, 2022

Signed-off-by: Jaeyeon Kim [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1919

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jul 27, 2022

Coverage Status

Coverage remained the same at 72.974% when pulling eb38f2c on anencore94:hotfix/sdk-list-trials-filter into 3b37d93 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anencore94, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anencore94
Copy link
Member Author

/retest

@anencore94
Copy link
Member Author

I guess there was some network issue for failed e2e test. How to re-run such github action workflow ? @gaocegege

@gaocegege
Copy link
Member

I rerun the test manually.

There is no way to trigger github action with the bot, I think.

@google-oss-prow google-oss-prow bot merged commit 42bc6a9 into kubeflow:master Jul 30, 2022
@anencore94 anencore94 deleted the hotfix/sdk-list-trials-filter branch July 30, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list_trials function do not respect experiment name filter
3 participants