Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mysql registry and tag to get security updates #1796

Closed
wants to merge 1 commit into from

Conversation

juliusvonkohout
Copy link
Member

What this PR does / why we need it:

Please use proper registry names and a proper tag to get security updates for mysql 8.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juliusvonkohout
To complete the pull request process, please assign johnugeorge after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout changed the title Update mysql.yaml Update mysql registry and tag to get security updates Jan 26, 2022
@juliusvonkohout
Copy link
Member Author

@andreyvelich i do not know whether is is a build problem again, but you really should use mysql with security fixes.

@andreyvelich
Copy link
Member

@juliusvonkohout Please check this PR: #1594.
We want to use the specific mysql image to avoid errors like:

[InnoDB] Cannot boot server version 80017 on data directory built by version 80018. Downgrade is not supported

If 8.0.26 version has some security issues, we can update the patch version.

/cc @kubeflow/wg-automl-leads @munagekar

@google-oss-prow google-oss-prow bot requested a review from a team February 1, 2022 12:19
@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: munagekar.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@juliusvonkohout Please check this PR: #1594.
We want to use the specific mysql image to avoid errors like:

[InnoDB] Cannot boot server version 80017 on data directory built by version 80018. Downgrade is not supported

If 8.0.26 version has some security issues, we can update the patch version.

/cc @kubeflow/wg-automl-leads @munagekar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliusvonkohout
Copy link
Member Author

@juliusvonkohout Please check this PR: #1594.
We want to use the specific mysql image to avoid errors like:

[InnoDB] Cannot boot server version 80017 on data directory built by version 80018. Downgrade is not supported

If 8.0.26 version has some security issues, we can update the patch version.

/cc @kubeflow/wg-automl-leads @munagekar

Thank you for the clarification. Imagepullpolicy:always would solve that, but i am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants