Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove each resource in Katib config #1729

Merged

Conversation

andreyvelich
Copy link
Member

This PR: #1564 allows user to nuke resource for Suggestion and Metrics Collector, but user has to set limits and requests as -1 to nuke it.

For some use-cases, users want to remove only limits or requests for resources.
After this PR they can do it.

/assign @gaocegege @johnugeorge @sravi999 @tenzen-y @anencore94

@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: sravi999.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This PR: #1564 allows user to nuke resource for Suggestion and Metrics Collector, but user has to set limits and requests as -1 to nuke it.

For some use-cases, users want to remove only limits or requests for resources.
After this PR they can do it.

/assign @gaocegege @johnugeorge @sravi999 @tenzen-y @anencore94

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sravi999
Copy link

sravi999 commented Nov 4, 2021

Thanks you very much @andreyvelich for your PR

@tenzen-y
Copy link
Member

tenzen-y commented Nov 4, 2021

LGTM!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 4, 2021
@google-oss-robot google-oss-robot merged commit e72e5c8 into kubeflow:master Nov 4, 2021
@andreyvelich andreyvelich deleted the config-allow-empty-resources branch November 4, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants