Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS for charm operators #1718

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

ca-scribner
Copy link
Contributor

Cycles incoming and outgoing Canonical team members for the charm operators

Cycles incoming and outgoing Canonical team members for the charm operators
@aws-kf-ci-bot
Copy link
Contributor

Hi @ca-scribner. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ca-scribner
Copy link
Contributor Author

/assign @DomFleischmann @knkski

@knkski
Copy link
Contributor

knkski commented Oct 19, 2021

/lgtm

@knkski
Copy link
Contributor

knkski commented Oct 19, 2021

@ca-scribner you may need to add yourself as a kubeflow contributor first.

@ca-scribner
Copy link
Contributor Author

ca-scribner commented Oct 20, 2021 via email

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege
Copy link
Member

/ok-to-test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.671% when pulling 8024014 on ca-scribner:patch-1 into 195db29 on kubeflow:master.

@johnugeorge
Copy link
Member

/verify-owners

@johnugeorge
Copy link
Member

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ca-scribner, gaocegege, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit e4cde95 into kubeflow:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants