Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: increase test timeout #1654

Merged

Conversation

anencore94
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
#1649

Checklist:

  • Docs included if any changes are user facing

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anencore94 Thank you for taking this!
Are you sure that increasing timeout will help to avoid flaky unit tests ?

For example in this failed test: https://github.com/kubeflow/katib/runs/3523610062?check_suite_focus=true.
Trial status was updated to Metrics Unavailable, but tests were failed on the previous step, where we compare observation results.

I think to fix it, we might need to split running Experiments in the different unit tests.

For example, currently in the TestReconcileBatchJob we run 3 Experiments:

  1. Trial run with "Failed" BatchJob
  2. Trail with "Complete" BatchJob and Available metrics.
  3. Trail with "Complete" BatchJob and Unavailable metrics.

Maybe we should split it in 3 different unit tests with separate test managers.

WDYT @anencore94 @gaocegege @johnugeorge ?

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anencore94, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 1ca6798 into kubeflow:master Sep 6, 2021
@gaocegege
Copy link
Member

Sorry for the quick merge.

I think we can increase it and see If it works. In the best case, we should split the test cases. Should we create an issue for it?

@andreyvelich
Copy link
Member

No worries @gaocegege :)
Yes, let's continue the discussion under #1649.

@anencore94 anencore94 deleted the enhance/change_test_timeout branch July 30, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants