Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to sdi #1555

Merged
merged 2 commits into from
Jun 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions operators/katib-controller/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ops==1.0.1
git+git://github.com/juju-solutions/resource-oci-image.git#egg=oci_image
ops==1.2.0
oci-image==1.0.0
4 changes: 2 additions & 2 deletions operators/katib-db-manager/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ops==1.0.1
git+git://github.com/juju-solutions/resource-oci-image.git#egg=oci_image
ops==1.2.0
oci-image==1.0.0
6 changes: 4 additions & 2 deletions operators/katib-ui/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ resources:
auto-fetch: true
upstream-source: docker.io/kubeflowkatib/katib-ui:v1beta1-a96ff59
requires:
service-mesh:
interface: service-mesh
ingress:
interface: ingress
schema: https://raw.githubusercontent.com/canonical/operator-schemas/master/ingress.yaml
versions: [v1]
provides:
katib-ui:
interface: http
Expand Down
5 changes: 3 additions & 2 deletions operators/katib-ui/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
ops==1.0.1
git+git://github.com/juju-solutions/resource-oci-image.git#egg=oci_image
ops==1.2.0
oci-image==1.0.0
serialized-data-interface==0.2.2
35 changes: 32 additions & 3 deletions operators/katib-ui/src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@

import logging

from oci_image import OCIImageResource, OCIImageResourceError
from ops.charm import CharmBase
from ops.main import main
from ops.model import ActiveStatus, MaintenanceStatus

from oci_image import OCIImageResource, OCIImageResourceError
from ops.model import ActiveStatus, BlockedStatus, MaintenanceStatus, WaitingStatus
from serialized_data_interface import (
NoCompatibleVersions,
NoVersionsListed,
get_interfaces,
)

logger = logging.getLogger(__name__)

Expand All @@ -22,9 +26,34 @@ def __init__(self, framework):
self.model.unit.status = ActiveStatus()
return

try:
self.interfaces = get_interfaces(self)
except NoVersionsListed as err:
self.model.unit.status = WaitingStatus(str(err))
return
except NoCompatibleVersions as err:
self.model.unit.status = BlockedStatus(str(err))
return
else:
self.model.unit.status = ActiveStatus()

self.image = OCIImageResource(self, "oci-image")
self.framework.observe(self.on.install, self.set_pod_spec)
self.framework.observe(self.on.upgrade_charm, self.set_pod_spec)
self.framework.observe(
self.on["ingress"].relation_changed,
self.configure_ingress,
)

def configure_ingress(self, event):
if self.interfaces["ingress"]:
self.interfaces["ingress"].send_data(
{
"prefix": "/katib/",
"service": self.model.app.name,
"port": self.model.config["port"],
}
)

def set_pod_spec(self, event):
self.model.unit.status = MaintenanceStatus("Setting pod spec")
Expand Down