Support Sobol's Quasirandom Sequence using Goptuna. #1523
Conversation
google-oss-robot
requested review from
andreyvelich,
johnugeorge and
sperlingxx
| @@ -10,6 +10,7 @@ export const AlgorithmNames = { | |||
| [AlgorithmsEnum.BAYESIAN_OPTIMIZATION]: 'Bayesian Optimization', | |||
| [AlgorithmsEnum.TPE]: 'Tree of Parzen Estimators', | |||
| [AlgorithmsEnum.CMAES]: 'Covariance Matrix Adaptation: Evolution Strategy', | |||
| [AlgorithmsEnum.SOBOL]: 'Sobol Quasirandom Sequence', | |||
There was a problem hiding this comment.
I cheked the new Katib UI.
c-bata
changed the title
There was a problem hiding this comment.
Thank you for the great contribution @c-bata!
Just one small question from me.
cc @gaocegege @johnugeorge
| @@ -21,6 +21,8 @@ Table of Contents | |||
| * [BOHB](#bohb) | |||
| * [TPE](#tpe) | |||
| * [SMAC](#smac) | |||
| * [CMA-ES](#cma-es) | |||
| * [Sobol](#sobol) | |||
There was a problem hiding this comment.
I think we should have the table somewhere in the docs with all supported Frameworks and Algorithms that these Suggestions support. Eventually, we don't need to modify the proposals docs.
WDYT @gaocegege @c-bata @johnugeorge ?
We can do it in the following PR.
There was a problem hiding this comment.
I think we should have the table somewhere in the docs with all supported Frameworks and Algorithms that these Suggestions support. Eventually, we don't need to modify the proposals docs.
Sounds good! Should I revert the changes of suggestion.md?
There was a problem hiding this comment.
I think we can leave this change in suggestion.md for now.
That will simplify the process for us to create the doc table.
|
LGTM from my side, @gaocegege @johnugeorge @kimwnasptd Please take a look. |
|
@c-bata Please can you also add Sobol algorithm support to the documentation: https://www.kubeflow.org/docs/components/katib/experiment/#search-algorithms-in-detail |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, c-bata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andreyvelich Thank you! I've just opened kubeflow/website#2703 👍 |
What this PR does / why we need it:
Added Sobol's quasirandom sequence support. See the paper S. Joe and F. Y. Kuo, Remark on Algorithm 659: Implementing Sobol's quasirandom sequence generator, ACM Trans. Math. Softw. 29, 49-57 (2003). for details.
np.random.rand()(seed=0)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Refs #1283
Special notes for your reviewer:
None.
Release note: