Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Go modules #1438

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

andreyvelich
Copy link
Member

We should migrate to Go modules from dep since it is not longer supported from 2020: https://github.com/golang/dep#dep.
Also to avoid errors like this: #1436 (comment).
Currently, I am using the same package versions with k8s.io/kubernetes v1.13.3 and sigs.k8s.io/controller-runtime v0.1.9 which is very old.

Unfortunately, I can't switch to the newer version because of this: #1405.
Controller runtime doesn't have dynamic webhook creation from v0.2.0.
We should disable dynamic webhook creation, update the versions and clean-up modules.

As well I fixed folder name in Build Docker images GitHub actions workflow. What do you think @DomFleischmann @RFMVasconcelos ?

Please take a look @gaocegege @johnugeorge.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

The tests are passed.
Can you check it @gaocegege @johnugeorge, please ?

@andreyvelich andreyvelich changed the title [WIP] Migrate to Go modules Migrate to Go modules Feb 18, 2021
@johnugeorge
Copy link
Member

/lgtm

@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5320764 into kubeflow:master Feb 18, 2021
@gaocegege
Copy link
Member

Should we use K8s v1.16.9 like tf-operator https://github.com/kubeflow/tf-operator/blob/master/go.mod#L33

@andreyvelich
Copy link
Member Author

andreyvelich commented Feb 19, 2021

Should we use K8s v1.16.9 like tf-operator https://github.com/kubeflow/tf-operator/blob/master/go.mod#L33

I think once we fix problems with Webhooks we can directly switch to the latest version of controller-runtime - v0.8.2 and K8s. - v1.19 or v1.20

@andreyvelich andreyvelich mentioned this pull request Feb 19, 2021
@andreyvelich andreyvelich deleted the migrate-to-go-modules branch October 6, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants