Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Update supported algorithms #1070

Merged
merged 2 commits into from
Feb 27, 2020
Merged

UI: Update supported algorithms #1070

merged 2 commits into from
Feb 27, 2020

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Feb 27, 2020 •
edited by jlewi
Loading

I updated Katib supported algorithms in the UI and I changed default value for additionalMetricNames, since we are using Train-accuracy metric in the main Katib training container.

/assign @johnugeorge

This change is Reviewable

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

1 similar comment
@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3a19e1c into kubeflow:master Feb 27, 2020
@andreyvelich andreyvelich deleted the ui-update-supported-algorithms branch October 6, 2021 00:23
@andreyvelich andreyvelich restored the ui-update-supported-algorithms branch October 6, 2021 00:23
@andreyvelich andreyvelich deleted the ui-update-supported-algorithms branch October 6, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinan-zhou jinan-zhou Awaiting requested review from jinan-zhou

@garganubhav garganubhav Awaiting requested review from garganubhav

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreyvelich @johnugeorge @k8s-ci-robot