fix: Remove name

Signed-off-by: Ce Gao <[email protected]>
kubeflow · Sep 4, 2019 · fc810de · fc810de
1 parent 610d45a
commit fc810de
Showing 1 changed file with 5 additions and 49 deletions.
diff --git a/docs/proposals/suggestion.md b/docs/proposals/suggestion.md
@@ -80,7 +80,6 @@ type SuggestionStatus struct {
 type TrialAssignment struct {
 	// Suggestion results
 	Assignments []ParameterAssignment `json:"assignments,omitempty"`
-	Name        string                `json:"name,omitempty"`
 }
 
 type ParameterAssignment struct {
@@ -339,46 +338,7 @@ status:
           value: adam
 ```
 
-Then Experiment controller creates the trials and set Suggestion status (Optional, not decided):
-
-```yaml
-apiVersion: "kubeflow.org/v1alpha2"
-kind: Suggestion
-metadata:
-  namespace: kubeflow
-  name: random-experiment
-spec:
-  algorithmName: random
-  suggestions: 3
-status:
-  assignments:
-    - name: random-experiment-fsa2f
-      assignments:
-        - name: --lr
-          value: 0.02
-        - name: --num-layers
-          value: 4
-        - name: --optimizer
-          value: sgd
-    - name: random-experiment-hoj53
-      assignments:
-        - name: --lr
-          value: 0.021
-        - name: --num-layers
-          value: 3
-        - name: --optimizer
-          value: adam
-    - name: random-experiment-12lkj
-      assignments:
-        - name: --lr
-          value: 0.03
-        - name: --num-layers
-          value: 5
-        - name: --optimizer
-          value: adam
-```
-
-When there is one trial finished, Experiment controller will ask Suggestion controller for a new suggestion:
+Then Experiment controller creates the trial. When there is one trial finished, Experiment controller will ask Suggestion controller for a new suggestion:
 
 ```yaml
 apiVersion: "kubeflow.org/v1alpha2"
@@ -391,32 +351,28 @@ spec:
   suggestions: 4
 status:
   assignments:
-    - name: random-experiment-fsa2f
-      assignments:
+    - assignments:
         - name: --lr
           value: 0.02
         - name: --num-layers
           value: 4
         - name: --optimizer
           value: sgd
-    - name: random-experiment-hoj53
-      assignments:
+    - assignments:
         - name: --lr
           value: 0.021
         - name: --num-layers
           value: 3
         - name: --optimizer
           value: adam
-    - name: random-experiment-12lkj
-      assignments:
+    - assignments:
         - name: --lr
           value: 0.03
         - name: --num-layers
           value: 5
         - name: --optimizer
           value: adam
-    - name: random-experiment-ybfd3
-      assignments:
+    - assignments:
         - name: --lr
           value: 0.012
         - name: --num-layers