py sdk create_exp - added type validation

Signed-off-by: Bharath Krishna <[email protected]>
kubeflow · Apr 2, 2024 · c583c68 · c583c68
1 parent 56b3f31
commit c583c68
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py b/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py
@@ -94,10 +94,15 @@ def create_experiment(
         namespace = namespace or self.namespace
 
         experiment_name = None
-        if experiment.metadata.name is not None:
-            experiment_name = experiment.metadata.name
-        elif experiment.metadata.generate_name is not None:
-            experiment_name = experiment.metadata.generate_name
+        if type(experiment) == models.V1beta1Experiment:
+            if experiment.metadata.name is not None:
+                experiment_name = experiment.metadata.name
+            elif experiment.metadata.generate_name is not None:
+                experiment_name = experiment.metadata.generate_name
+        elif "name" in experiment["metadata"]:
+            experiment_name = experiment["metadata"]["name"]
+        elif "generate_name" in experiment["metadata"]:
+            experiment_name = experiment["metadata"]["generate_name"]
 
         if experiment_name is None:
             raise ValueError("Experiment must have a name or generateName")