feat: Add event when the reconcile is failed (#879)

* feat: Add event when the reconcile is failed Signed-off-by: Ce Gao <[email protected]> * fix: Use format Signed-off-by: Ce Gao <[email protected]>
kubeflow · Oct 14, 2019 · 8221592 · 8221592
1 parent d93b602
commit 8221592
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/controller.v1alpha3/trial/trial_controller.go b/pkg/controller.v1alpha3/trial/trial_controller.go
@@ -179,6 +179,9 @@ func (r *ReconcileTrial) Reconcile(request reconcile.Request) (reconcile.Result,
 		err := r.reconcileTrial(instance)
 		if err != nil {
 			logger.Error(err, "Reconcile trial error")
+			r.recorder.Eventf(instance,
+				corev1.EventTypeWarning, ReconcileFailedReason,
+				"Failed to reconcile: %v", err)
 			return reconcile.Result{}, err
 		}
 	}

diff --git a/pkg/controller.v1alpha3/trial/trial_controller_consts.go b/pkg/controller.v1alpha3/trial/trial_controller_consts.go
@@ -17,4 +17,5 @@ const (
 	JobSucceededReason          = "JobSucceeded"
 	JobMetricsUnavailableReason = "MetricsUnavailable"
 	JobFailedReason             = "JobFailed"
+	ReconcileFailedReason       = "ReconcileFailed"
 )