Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElayAharoni as member to kubeflow-org #698

Conversation

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Copy link

Hi @ElayAharoni. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

I'm happy to sponsor @ElayAharoni's membership.

/lgtm
/ok-to-test

@HumairAK
Copy link
Contributor

Also happy to sponsor @ElayAharoni's membership.

/lgtm

@hbelmiro
Copy link
Contributor

cc @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

/retest

1 similar comment
@hbelmiro
Copy link
Contributor

/retest

@google-oss-prow google-oss-prow bot merged commit a81648e into kubeflow:master Aug 21, 2024
3 checks passed
@terrytangyuan
Copy link
Member

@zijianjoy Could you help look into why the membership change is not effective? @ElayAharoni has not received the invite yet

@zijianjoy
Copy link
Contributor

Looks like github is not happy about having people in both admin and member roles, created #704 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ElayAharoni as member to kubeflow org
5 participants