Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD_VERSION is not correctly shown in the UI #25

Open
capkurmagati opened this issue Feb 17, 2023 · 2 comments · May be fixed by kubeflow/kubeflow#6978
Open

BUILD_VERSION is not correctly shown in the UI #25

capkurmagati opened this issue Feb 17, 2023 · 2 comments · May be fixed by kubeflow/kubeflow#6978

Comments

@capkurmagati
Copy link

/kind bug

What steps did you take and what happened:
The BUILD_VERSION is not set in the centeraldashboard docker image.
https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/Dockerfile#L6
Because the kubeflowversion arg is not set in the Makefile.
https://github.com/kubeflow/kubeflow/blob/c946c624cd8974ef53cac04582e4714b466d546e/components/centraldashboard/Makefile#L33-L40

The UI falls back to use dev_local.
https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/webpack.config.js#L22

What did you expect to happen:
BUILD_VERSION is set and correctly shown on the central dashboard UI.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard):
  • kfctl version: (use kfctl version):
  • Kubernetes platform: (e.g. minikube)
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@andreyvelich
Copy link
Member

/transfer dashboard

Copy link

@capkurmagati: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

What steps did you take and what happened:
The BUILD_VERSION is not set in the centeraldashboard docker image.
https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/Dockerfile#L6
Because the kubeflowversion arg is not set in the Makefile.
https://github.com/kubeflow/kubeflow/blob/c946c624cd8974ef53cac04582e4714b466d546e/components/centraldashboard/Makefile#L33-L40

The UI falls back to use dev_local.
https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/webpack.config.js#L22

What did you expect to happen:
BUILD_VERSION is set and correctly shown on the central dashboard UI.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard):
  • kfctl version: (use kfctl version):
  • Kubernetes platform: (e.g. minikube)
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants