delete podgroup before clean job (#180)

Signed-off-by: bert.li <[email protected]>

pkg/controller.v1/common/job.go

@@ -101,10 +101,6 @@ func (jc *JobController) ReconcileJobs(
 			return err
 		}
 
-		if err := jc.CleanupJob(runPolicy, jobStatus, job); err != nil {
-			return err
-		}
-
 		if jc.Config.EnableGangScheduling {
 			jc.Recorder.Event(runtimeObject, v1.EventTypeNormal, "JobTerminated", "Job has been terminated. Deleting PodGroup")
 			if err := jc.DeletePodGroup(metaObject); err != nil {
@@ -115,6 +111,10 @@ func (jc *JobController) ReconcileJobs(
 			}
 		}
 
+		if err := jc.CleanupJob(runPolicy, jobStatus, job); err != nil {
+			return err
+		}
+
 		// At this point the pods may have been deleted.
 		// 1) If the job succeeded, we manually set the replica status.
 		// 2) If any replicas are still active, set their status to succeeded.