Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support config request resources in kserve runtime #1050

Conversation

gujingit
Copy link
Contributor

@gujingit gujingit commented Mar 7, 2024

/kind feature

The default request resource of kserve is

requests:
          cpu: 1
          memory: 2Gi

So, if set --cpu=500m --memory=1Gi by command line, the inference pod can not running.

Release Note

If the user sets `--cpu=xxx --memory=xxx` through the command line, the request and limit resources need to be configured at the same time.

@Syulin7
Copy link
Collaborator

Syulin7 commented Mar 7, 2024

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gujingit, Syulin7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b7f0ecf into kubeflow:master Mar 7, 2024
5 checks passed
@gujingit gujingit deleted the feature/support-config-kserve-request branch April 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants