Detect docker image SHA instead of tag #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2021 11:59
Just reading the Pod spec's container image is not enough to have a reproducible reference to the current image, because an image tag can be re-assigned to newer builds, in the future (e.g. when using the `latest` tag). The only way to have reproducible reference is by using the image manifest's `sha`. Kubernetes exposes this in the Pod's `status`, under `containerStatuses` [1], in the field `imageID`. In the case this field is empty (this could happen when the image was built locally), then fallback to reading the Pod's container `image` field. [1] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.20/#containerstatus-v1-core # noqa: 501 Signed-off-by: Stefano Fioravanzo <[email protected]> Reviewed-by: Ilias Katsakioris <[email protected]>
Use common util to get the workflow Signed-off-by: Stefano Fioravanzo <[email protected]> Reviewed-by: Ilias Katsakioris <[email protected]>
elikatsis
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the detection of the base docker image being used by the Pod, retrieving the image SHA (when available).
This ensures that reproducibility even when the base image has a non-reproducible tag (e.g.
latest)