docker: Fix Dockerfiles (enum & KFP installation) #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Force the installation of enum34==1.1.8. Other versions raise errors on KFP installation, this happens since KFP version 1.1.0. The faulty dependency is docstring-parser [*] * Do not install KFP separately, let Kale requirements do it [*] `enum34` patches the built-in Enum and is known to cause issues with many libraries. In general, the solution is to just uninstall it. Most probably this dependency is needed by the base image's TensorFlow, thus we just pin it to a version that work with KFP as well. Closes kubeflow-kale#274 Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
StefanoFioravanzo
force-pushed
the
fix-dockerfile
branch
from
0f23502 to
58906ca
Compare
StefanoFioravanzo
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on KFP installation
Closes #274
Signed-off-by: Ilias Katsakioris [email protected]