Enable specifying the storage class and access modes of the created PVCs #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Field's value is `None` don't run the validation process. Validators are *not* supposed to check if the value is set or not, we should control that by setting the `required` flag to True. Signed-off-by: Stefano Fioravanzo <[email protected]> Reviewed-by: Ilias Katsakioris <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
Signed-off-by: Ilias Katsakioris <[email protected]> Reviewed-by: Stefano Fioravanzo <[email protected]>
StefanoFioravanzo
force-pushed
the
feature-volume-select-class-n-modes
branch
from
c27ff1c
to
7406451
Compare
StefanoFioravanzo
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following two features:
It also extends the Kale CLI as well as the lab extensions to set these options.
Note: This PR, allows both a global and a per-PVC configuration for the above, giving priority to the per-PVC one. However, the per-PVC configuration is not available through the lab extension because it looks like it just complicates things.
Closes #51
Closes #161
Closes #207