-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed X logo in dark mode and removed x.svg file #672
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5d34210
to
3556850
Compare
@Shelley-BaoYue kindly review pls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all looks good, but plz squash some commits https://kubeedge.io/docs/developer/Supplemental_developer_guide#ensuring-to-squash-similiar-commits
Signed-off-by: Dhairya Majmudar <[email protected]> fix: eof problem fixed Signed-off-by: Dhairya Majmudar <[email protected]> fix: width and height Signed-off-by: Dhairya Majmudar <[email protected]>
4545c36
to
cf6b88e
Compare
Thank you @wbc6080 for review I've squashed the commits. |
Thanks for your contributions! |
Which issue(s) this PR fixes:
Fixes #671
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
N/A
Other information:
N/A