Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed X logo in dark mode and removed x.svg file #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:
Fixes #671

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  1. Fixes the X logo in dark mode by converting the logo into its white gradient while in dark mode.
  2. Removed x.svg file as its not used anymore in other parts of codebase
  • What is the current behavior? (You can also link to an open issue here)

Screenshot from 2025-01-27 10-04-08

  • What is the new behavior (if this is a feature change)?
    image

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    N/A

  • Other information:
    N/A

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2025
@DhairyaMajmudar
Copy link
Author

@Shelley-BaoYue kindly review pls.

src/css/custom.css Outdated Show resolved Hide resolved
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Dhairya Majmudar <[email protected]>

fix: eof problem fixed

Signed-off-by: Dhairya Majmudar <[email protected]>

fix: width and height

Signed-off-by: Dhairya Majmudar <[email protected]>
@DhairyaMajmudar
Copy link
Author

Thank you @wbc6080 for review I've squashed the commits.

@wbc6080
Copy link
Contributor

wbc6080 commented Feb 7, 2025

Thanks for your contributions!
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: X (Formely twitter) logo in not visible in dark mode
4 participants