Add logging to readme #1409
Merged
Add logging to readme #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmdresser
approved these changes
May 6, 2022
|
Like the output but this doesn't feel like quite the right location for this... |
|
Maybe below the config options table? |
|
Generally, the explanations and info are above the config options so a user doesn't have to scroll forever to see things, but I can move it |
|
Open to other locations, but this is the primary open README for installing Kubecost. Logging detail that close to the install steps feels like we run the risk of distracting / overwhelming a first time user. Maybe that's not the right way of phrasing... let me know if I can articulate better. |
|
Makes sense, moved it to the bottom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Add logging to readme
Related to: opencost/opencost#1178