Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White List LoadBalancer Cost #1402

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

mbolt35
Copy link
Contributor

@mbolt35 mbolt35 commented May 3, 2022

What does this PR change?

  • Add kubecost_load_balancer_cost to Metric White List

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Fix for missing Load Balancers on hosted deployments which use a service discovery for kubecost-agent

* Add kubecost_load_balancer_cost to Metric White List
@mbolt35 mbolt35 self-assigned this May 3, 2022
@mbolt35 mbolt35 requested a review from AjayTripathy May 3, 2022 20:04
@dwbrown2
Copy link
Contributor

dwbrown2 commented May 3, 2022

Just curious, would this metric map to this block?

# defaultModelPricing: # default monthly resource prices, used predominately for on-prem clusters
# CPU: 28.0
# spotCPU: 4.86
# RAM: 3.09
# spotRAM: 0.65
# GPU: 693.50
# spotGPU: 225.0
# storage: 0.04
# zoneNetworkEgress: 0.01
# regionNetworkEgress: 0.01
# internetNetworkEgress: 0.12

If so, worth adding a default reference? We've had that as a feature request.

Apologies if this is different.

@AjayTripathy
Copy link
Contributor

Just curious, would this metric map to this block?

# defaultModelPricing: # default monthly resource prices, used predominately for on-prem clusters
# CPU: 28.0
# spotCPU: 4.86
# RAM: 3.09
# spotRAM: 0.65
# GPU: 693.50
# spotGPU: 225.0
# storage: 0.04
# zoneNetworkEgress: 0.01
# regionNetworkEgress: 0.01
# internetNetworkEgress: 0.12

If so, worth adding a default reference? We've had that as a feature request.

Apologies if this is different.

It sounds like a good feature request but it isn't configurable here without an additional corresponding codepath to set the pricing in the metrics emitter. Can you file that separately?

@dwbrown2
Copy link
Contributor

@mbolt35 good to merge?

cc @AdamStack18

@mbolt35 mbolt35 merged commit 9b15909 into develop May 11, 2022
@Adam-Stack-PM Adam-Stack-PM added v1.94 and removed v1.94 labels May 12, 2022
@Adam-Stack-PM Adam-Stack-PM added the bug Something isn't working label May 24, 2022
@chipzoller chipzoller deleted the bolt/add-kubecost-loadbalancer branch October 4, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.94
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants