adding kubemodel.etlCloudAsset #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1.92, you guys changed the cost-analyzer-deployment template.yaml
- name : ETL_CLOUD_USAGE_ENABLED
{{- if eq .Values.kubecostModel.etlCloudAsset false }}
value: "false"
There is no default value assigned to etlCloudAsset even not in Values.yaml
|
Hi @nareshagrawal, I believe this is the intended behavior. The docs mention here that |
|
Apologies if you encountered development issues in the develop branch @nareshagrawal -- it should now be sync'd back to master and runnable with this PR merged. #1380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.92, you guys changed the cost-analyzer-deployment template.yaml
{{- if eq .Values.kubecostModel.etlCloudAsset false }}
value: "false"
There is no default value assigned to etlCloudAsset even not in Values.yaml
What does this PR change?
Adding default value to etlCloudAsset
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
Have you made an update to documentation?