-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX prometheus ingress #1375
Merged
Merged
FIX prometheus ingress #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoerner
approved these changes
Apr 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for the contribution! |
AjayTripathy
approved these changes
Apr 18, 2022
AjayTripathy
added a commit
that referenced
this pull request
May 3, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * Bump to v1.93.0-rc.0 Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
May 10, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * Bump to v1.93.0-rc.0 Commit auto-generated by release script. * Bump to v1.93.0-rc.1 Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
May 11, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * Bump to v1.93.0-rc.0 Commit auto-generated by release script. * Bump to v1.93.0-rc.1 Commit auto-generated by release script. * Bump to v1.93.0 Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
May 13, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * Bump to v1.93.0-rc.0 Commit auto-generated by release script. * Bump to v1.93.0-rc.1 Commit auto-generated by release script. * Bump to v1.93.0 Commit auto-generated by release script. * Bump to v1.93.1 Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
May 24, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * Bump to v1.93.0-rc.0 Commit auto-generated by release script. * Bump to v1.93.0-rc.1 Commit auto-generated by release script. * Bump to v1.93.0 Commit auto-generated by release script. * Bump to v1.93.1 Commit auto-generated by release script. * vbumpb Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Thomas Evans <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
May 31, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Neal Ormsbee <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Jesse Goodier <[email protected]> Co-authored-by: Sean Pomeroy <[email protected]> Co-authored-by: wolfeaustin <[email protected]> Co-authored-by: Morten Mjelva <[email protected]> Co-authored-by: James Jarrett <[email protected]> Co-authored-by: Brandon High <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
Jun 3, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Neal Ormsbee <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Jesse Goodier <[email protected]> Co-authored-by: Sean Pomeroy <[email protected]> Co-authored-by: wolfeaustin <[email protected]> Co-authored-by: Morten Mjelva <[email protected]> Co-authored-by: James Jarrett <[email protected]> Co-authored-by: Brandon High <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
Jun 7, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Neal Ormsbee <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Jesse Goodier <[email protected]> Co-authored-by: Sean Pomeroy <[email protected]> Co-authored-by: wolfeaustin <[email protected]> Co-authored-by: Morten Mjelva <[email protected]> Co-authored-by: James Jarrett <[email protected]> Co-authored-by: Brandon High <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
Jun 9, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Neal Ormsbee <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Jesse Goodier <[email protected]> Co-authored-by: Sean Pomeroy <[email protected]> Co-authored-by: wolfeaustin <[email protected]> Co-authored-by: Morten Mjelva <[email protected]> Co-authored-by: James Jarrett <[email protected]> Co-authored-by: Brandon High <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
Jun 9, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. * Bump to v1.94.2 (#1469) Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Neal Ormsbee <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Jesse Goodier <[email protected]> Co-authored-by: Sean Pomeroy <[email protected]> Co-authored-by: wolfeaustin <[email protected]> Co-authored-by: Morten Mjelva <[email protected]> Co-authored-by: James Jarrett <[email protected]> Co-authored-by: Brandon High <[email protected]>
AjayTripathy
added a commit
that referenced
this pull request
Jun 13, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <[email protected]> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <[email protected]> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. * Bump to v1.94.2 (#1469) Commit auto-generated by release script. * Bump to v1.94.3 (#1479) Commit auto-generated by release script. Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: keith.hand <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Niko Kovacevic <[email protected]> Co-authored-by: Naresh Agrawal <[email protected]> Co-authored-by: Cameron Hall <[email protected]> Co-authored-by: Ajay Tripathy <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Volodymyr Lisnyi <[email protected]> Co-authored-by: Michael Dresser <[email protected]> Co-authored-by: dschunack <[email protected]> Co-authored-by: Neal Ormsbee <[email protected]> Co-authored-by: Daniel Ramich <[email protected]> Co-authored-by: Dan Ramich <[email protected]> Co-authored-by: Sean Holcomb <[email protected]> Co-authored-by: Matt Bolt <[email protected]> Co-authored-by: Kaelan Patel <[email protected]> Co-authored-by: Jesse Goodier <[email protected]> Co-authored-by: Sean Pomeroy <[email protected]> Co-authored-by: wolfeaustin <[email protected]> Co-authored-by: Morten Mjelva <[email protected]> Co-authored-by: James Jarrett <[email protected]> Co-authored-by: Brandon High <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
this PR fixed issue with ingress
when ingress rule use
pathType: "Exact"
we gotdefault backend - 404
during Prometheus health check
http://prod-spok-kubecost-prometheus.domain.net/-/healthy
after we change this to
pathType: "Prefix"
we gotPrometheus is Healthy.
during Prometheus health check
http://prod-spok-kubecost-prometheus.domain.net/-/healthy
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
With helm update for running cost-analyzer helm release.
Have you made an update to documentation?
Not needed