Fixed Google Analytics Tag Name #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwbrown2
reviewed
Apr 15, 2022
| # Report Javascript errors | ||
| errorReporting: true | ||
| valuesReporting: true | ||
| # googleAnalyticsTag allows you to embed your Google Global Site Tag to track usage of Kubecost. |
There was a problem hiding this comment.
I think this should be a paid feature since it's mostly an enterprise use case. Want to mark as such? Happy to discuss.
There was a problem hiding this comment.
Happy to do that - Do we need to do anything other than mark it here and implement the gate on the front end?
There was a problem hiding this comment.
Can discuss, but my vote is just mark for now!
biancaburtoiu
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Changes the Google Analytics Tag environment variable name
Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or ZD tickets this PR addresses or fixes
None
How was this PR tested?
Manually
Have you made an update to documentation?
No